From 7447a02b43a71d5bc6d34694ae7a294f244b600c Mon Sep 17 00:00:00 2001 From: JeremyStarTM Date: Fri, 25 Aug 2023 16:16:54 +0200 Subject: [PATCH] Fix smgr not instantiating packedscene --- smgr.gd | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/smgr.gd b/smgr.gd index 0dba9ad..4d40413 100644 --- a/smgr.gd +++ b/smgr.gd @@ -62,7 +62,7 @@ func add_debug(resource_name:String) -> int: var err = core.error("SceneManager",core.Errors.SCENEMANAGER_ALREADY_LOADED,{"scene":resource_name,"overlay":"debug"}) logger.error("CORE/smgr.gd",err["error"]) return err["code"] - # In theory unecessary but if something for some reason did something very wrong it would be catched here + resource = resource.instantiate() if !debug_overlay_scene.has(resource_name) and debug_overlay.get_children().has(resource): core.exception("SceneManager","debug_overlay_scene does not contain \"" + resource_name + "\" but debug_overlay does") return core.Errors.CORE_EXCEPTION @@ -90,6 +90,7 @@ func add_menu(resource_name:String) -> int: var err = core.error("SceneManager",core.Errors.SCENEMANAGER_ALREADY_LOADED,{"scene":resource_name,"overlay":"menu"}) logger.error("CORE/smgr.gd",err["error"]) return err["code"] + resource = resource.instantiate() if !menu_overlay_scene.has(resource_name) and menu_overlay.get_children().has(resource): core.exception("SceneManager","menu_overlay_scene does not contain \"" + resource_name + "\" but menu_overlay does") return core.Errors.CORE_EXCEPTION @@ -116,6 +117,7 @@ func add_cutscene(resource_name:String) -> int: var err = core.error("SceneManager",core.Errors.SCENEMANAGER_ALREADY_LOADED,{"scene":resource_name,"overlay":"cutscene"}) logger.error("CORE/smgr.gd",err["error"]) return err["code"] + resource = resource.instantiate() if cutscene_overlay_scene != resource_name and cutscene_overlay.get_children().has(resource): core.exception("SceneManager","cutscene_overlay_scene does not contain \"" + resource_name + "\" but cutscene_overlay does") return core.Errors.CORE_EXCEPTION @@ -142,6 +144,7 @@ func add_action(resource_name:String) -> int: var err = core.error("SceneManager",core.Errors.SCENEMANAGER_ALREADY_LOADED,{"scene":resource_name,"overlay":"action"}) logger.error("CORE/smgr.gd",err["error"]) return err["code"] + resource = resource.instantiate() if action_overlay_scene != resource_name and action_overlay.get_children().has(resource): core.exception("SceneManager","action_overlay_scene does not contain \"" + resource_name + "\" but action_overlay does") return core.Errors.CORE_EXCEPTION