From b4e4a4df1fde35eba7add6123528a7137724e4c9 Mon Sep 17 00:00:00 2001 From: JeremyStarTM Date: Wed, 24 Apr 2024 01:39:38 +0200 Subject: [PATCH] Reimplement 'logger_detect_verbose_mode' setting --- docs/docs/reference/config.md | 3 +-- src/classes/config.gd | 4 ++-- src/core.gd | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/docs/docs/reference/config.md b/docs/docs/reference/config.md index f18d615..0a40c23 100644 --- a/docs/docs/reference/config.md +++ b/docs/docs/reference/config.md @@ -30,8 +30,7 @@ Determines if the logger's output should be colored. Updating this during runtime does nothing. ::: Determines if the logger should check if running in verbose mode (see [`OS.is_stdout_verbose`](https://docs.godotengine.org/en/4.2/classes/class_os.html#class-os-method-is-stdout-verbose)). \ -Comes with a huge performance penalty on startup, delaying startup by about one to two seconds. \ -Update `verbose_mode` accordingly yourself if you've disabled this, or diagnostic log messages might appear messed up. \ +Update `verbose_mode` yourself accordingly if you've set this to `false`, or face messed up diagnostic log messages. \ ### *String* logger_format = *"%color%[%time%] [%level% %source%:%line%] %message%"* The template for all log messages Available placeholders are: `%time%`, `%time_ms%`, `%level%`, `%color%`, `%message%`, `%source%`, `%source_raw%`, `%function%` and `%line%` diff --git a/src/classes/config.gd b/src/classes/config.gd index ea358bb..4b4ce2b 100644 --- a/src/classes/config.gd +++ b/src/classes/config.gd @@ -26,8 +26,7 @@ class_name CoreConfiguration ## Determines if the logger's output should be colored. @export var logger_colored: bool ## Determines if the logger should check if running in verbose mode (see [method OS.is_stdout_verbose]).[br] -## Comes with a huge performance penalty on startup, delaying startup by about one to two seconds.[br] -## Update [code]verbose_mode[/code] accordingly yourself if you've disabled this, or diagnostic log messages might appear messed up.[br] +## Update [code]verbose_mode[/code] yourself accordingly if you've set this to [code]false[/code], or face messed up diagnostic log messages.[br] ## [b]Warning: [i]Updating this during runtime does nothing.[/i][/b] @export var logger_detect_verbose_mode: bool ## The template for all log messages.[br] @@ -72,6 +71,7 @@ func _init() -> void: # Logger logger_level = CoreTypes.LoggerLevel.INFO logger_colored = true + logger_detect_verbose_mode = true logger_format = "%color%[%time%] [%level% %origin%] %message%" logger_newlines_override = true logger_newlines_sizelimit = 40 diff --git a/src/core.gd b/src/core.gd index c25a1eb..5f65fe0 100644 --- a/src/core.gd +++ b/src/core.gd @@ -195,7 +195,7 @@ func apply_configuration() -> void: custom_modules[module]._pull_config() # Workaround - logger.verbose_mode = OS.is_stdout_verbose() + if config.logger_detect_verbose_mode: logger.verbose_mode = OS.is_stdout_verbose() # +++ custom module support +++ ## Registers a new custom module.