StarOpenSource/Engine
StarOpenSource/Engine
2
0
Fork 1
Code Issues 10 Pull requests Releases 9 Activity Actions

Fix debugFrames check and Window#icons type
All checks were successful
build-and-test / build (push) Successful in 1m12s
Details
build-and-test / test (push) Successful in 1m25s
Details
build-and-test / generate-javadoc (push) Successful in 1m29s
Details

Browse source
This commit is contained in:
JeremyStar™ 2024-10-16 13:03:19 +02:00
parent 643bda6c28
commit f6c99b66e8
Signed by: JeremyStarTM
GPG key ID: E366BAEF67E4704D
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
windowing/glfw/src/main/java/de/staropensource/engine/windowing/glfw/implementable/GlfwWindow.java
View file

@ -109,7 +109,7 @@ public final class GlfwWindow extends Window {
* @throws Exception stuff thrown by the {@link #initializeWindow()} and {@link #render()} methods of the implementing windowing API * @throws Exception stuff thrown by the {@link #initializeWindow()} and {@link #render()} methods of the implementing windowing API
* @since v1-alpha2 * @since v1-alpha2
*/ */
public GlfwWindow(@NotNull String name, @NotNull String title, @Nullable Path @NotNull [] icons, @NotNull Vec2i size, @NotNull Vec2i minimumSize, @NotNull Vec2i maximumSize, @NotNull Vec2i position, @NotNull WindowMode windowMode, @NotNull Monitor monitor, boolean resizable, boolean borderless, boolean focusable, boolean onTop, boolean transparent, boolean rendering) throws Exception { public GlfwWindow(@NotNull String name, @NotNull String title, @NotNull Path @Nullable [] icons, @NotNull Vec2i size, @NotNull Vec2i minimumSize, @NotNull Vec2i maximumSize, @NotNull Vec2i position, @NotNull WindowMode windowMode, @NotNull Monitor monitor, boolean resizable, boolean borderless, boolean focusable, boolean onTop, boolean transparent, boolean rendering) throws Exception {
super(name, title, icons, size, minimumSize, maximumSize, position, windowMode, monitor, resizable, borderless, focusable, onTop, transparent, rendering); super(name, title, icons, size, minimumSize, maximumSize, position, windowMode, monitor, resizable, borderless, focusable, onTop, transparent, rendering);
} }
@ -356,7 +356,7 @@ public final class GlfwWindow extends Window {
/** {@inheritDoc} */ /** {@inheritDoc} */
@ApiStatus.Experimental @ApiStatus.Experimental
@Override @Override
public void setIcons(@Nullable Path @NotNull [] icons) { public void setIcons(@NotNull Path @Nullable [] icons) {
getLogger().warn("GlfwWindow#setIcons is experimental and may cause engine or JVM crashes. Here be dragons!"); getLogger().warn("GlfwWindow#setIcons is experimental and may cause engine or JVM crashes. Here be dragons!");
// Ensure the window is not terminated // Ensure the window is not terminated

10
windowing/src/main/java/de/staropensource/engine/windowing/implementable/Window.java
View file

@ -222,7 +222,7 @@ public abstract class Window implements AutoCloseable {
* @since v1-alpha6 * @since v1-alpha6
*/ */
@Setter @Setter
private @Nullable Path @NotNull [] icons; private @NotNull Path @Nullable [] icons;
/** /**
* Contains the size of this window. * Contains the size of this window.
@ -508,7 +508,7 @@ public abstract class Window implements AutoCloseable {
* @throws Exception stuff thrown by the {@link #initializeWindow()} and {@link #render()} methods of the implementing windowing API * @throws Exception stuff thrown by the {@link #initializeWindow()} and {@link #render()} methods of the implementing windowing API
* @since v1-alpha2 * @since v1-alpha2
*/ */
protected Window(@NotNull String name, @NotNull String title, @Nullable Path @NotNull [] icons, @NotNull Vec2i size, @NotNull Vec2i minimumSize, @NotNull Vec2i maximumSize, @NotNull Vec2i position, @NotNull WindowMode windowMode, @NotNull Monitor monitor, boolean resizable, boolean borderless, boolean focusable, boolean onTop, boolean transparent, boolean rendering) throws Exception { protected Window(@NotNull String name, @NotNull String title, @NotNull Path @Nullable [] icons, @NotNull Vec2i size, @NotNull Vec2i minimumSize, @NotNull Vec2i maximumSize, @NotNull Vec2i position, @NotNull WindowMode windowMode, @NotNull Monitor monitor, boolean resizable, boolean borderless, boolean focusable, boolean onTop, boolean transparent, boolean rendering) throws Exception {
// Initialize variables // Initialize variables
this.uniqueIdentifier = UUID.randomUUID(); this.uniqueIdentifier = UUID.randomUUID();
this.name = name; this.name = name;
@ -657,7 +657,7 @@ public abstract class Window implements AutoCloseable {
* @see Window#icons * @see Window#icons
* @since v1-alpha6 * @since v1-alpha6
*/ */
private @Nullable Path @NotNull [] icons = null; private @NotNull Path @Nullable [] icons = null;
/** /**
* Contains the window size. * Contains the window size.
@ -849,7 +849,7 @@ public abstract class Window implements AutoCloseable {
* @see Window#icons * @see Window#icons
* @since v1-alpha6 * @since v1-alpha6
*/ */
public @Nullable Path @NotNull [] getIcons() { public @NotNull Path @Nullable [] getIcons() {
return icons; return icons;
} }
@ -1020,7 +1020,7 @@ public abstract class Window implements AutoCloseable {
* @see Window#icons * @see Window#icons
* @since v1-alpha6 * @since v1-alpha6
*/ */
public @NotNull Builder setIcons(@Nullable Path @NotNull [] icons) { public @NotNull Builder setIcons(@NotNull Path @Nullable [] icons) {
this.icons = icons; this.icons = icons;
return this; return this;
} }

2
windowing/src/main/java/de/staropensource/engine/windowing/implementable/api/ApiManagementClass.java
View file

@ -101,7 +101,7 @@ public abstract class ApiManagementClass {
// Check if delta time and frame count shall be printed to console. // Check if delta time and frame count shall be printed to console.
// Unless this code is ran 292 billion years into the future, // Unless this code is ran 292 billion years into the future,
// this should sufficiently disable the reporting feature. // this should sufficiently disable the reporting feature.
if (WindowingSubsystemConfiguration.getInstance().isDebugFrames()) if (!WindowingSubsystemConfiguration.getInstance().isDebugFrames())
reportDuration = Long.MAX_VALUE; reportDuration = Long.MAX_VALUE;
// Run while the 'output' is empty // Run while the 'output' is empty