feat: logging system rewrite #10
Labels
No labels
Blocked
ByBug
Blocked
ByDependency
Blocked
ByMissingFeature
Bug
Accepted
Bug
Fixed
Bug
In Progress
Bug
Invalid
Bug
ItWorksOnMyMachine
Bug
MoreInvestigation
Bug
New
Empty
FeatureRequest
Accepted
FeatureRequest
Implemented
FeatureRequest
In Progress
FeatureRequest
Invalid
FeatureRequest
New
FeatureRequest
PartiallyImplemented
FeatureRequest
WontAdd
Important
PR
BranchMerge
PR
BugFix
PR
Documentation
PR
FeatureAddition
PR
Miscellaneous
PR
Mixed
PR
New
PR
Tests
PR
Update
Roadmap
Stale
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Reference: StarOpenSource/Engine#10
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Feature description
I want the entire logging system to be rewritten.
What we have now is working, but bare bones. It could be much better.
Feature implementation
Instead of the setup we have now, where there is one big
Logger
class handling logging, oneCrashHandler
class just for crashes and aLoggerInstance
class serving as the middleman, I'd propose instead having multiple classes (e.g.CrashHandler
,LoggingProcessor
,LoggingThread
) for better code separation, repurposing our currentLoggerInstance
for a regularLogger
class having about the same function, makingLogRule
s a bit nicer to work with, and finally, adding a mode to fully disable logging, either for the engine or everything, which would benefit console applications greatly.Feature alternatives
Staying with the current logging system.
We could directly implement #4 in this FR. Two birds with one stone.