feat: logging system rewrite #10

Open
opened 2024-10-30 21:47:48 +01:00 by JeremyStarTM · 1 comment
Owner

Feature description

I want the entire logging system to be rewritten.

What we have now is working, but bare bones. It could be much better.

Feature implementation

Instead of the setup we have now, where there is one big Logger class handling logging, one CrashHandler class just for crashes and a LoggerInstance class serving as the middleman, I'd propose instead having multiple classes (e.g. CrashHandler, LoggingProcessor, LoggingThread) for better code separation, repurposing our current LoggerInstance for a regular Logger class having about the same function, making LogRules a bit nicer to work with, and finally, adding a mode to fully disable logging, either for the engine or everything, which would benefit console applications greatly.

Feature alternatives

Staying with the current logging system.

### Feature description I want the entire logging system to be rewritten. What we have now is working, but bare bones. It could be much better. ### Feature implementation Instead of the setup we have now, where there is one big `Logger` class handling logging, one `CrashHandler` class just for crashes and a `LoggerInstance` class serving as the middleman, I'd propose instead having multiple classes (e.g. `CrashHandler`, `LoggingProcessor`, `LoggingThread`) for better code separation, repurposing our current `LoggerInstance` for a regular `Logger` class having about the same function, making `LogRule`s a bit nicer to work with, and finally, adding a mode to fully disable logging, either for the engine or everything, which would benefit console applications greatly. ### Feature alternatives Staying with the current logging system.
JeremyStarTM added the
FeatureRequest
New
label 2024-10-30 21:47:48 +01:00
Author
Owner

We could directly implement #4 in this FR. Two birds with one stone.

We could directly implement #4 in this FR. Two birds with one stone.
JeremyStarTM added
FeatureRequest
In Progress
and removed
FeatureRequest
New
labels 2024-11-03 19:21:11 +01:00
JeremyStarTM added this to the v1-alpha8 milestone 2024-11-03 19:21:13 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: StarOpenSource/Engine#10
No description provided.