Proposed changes to the _use_current functionality

yarost12 commented

2024-11-19 01:23:50 +01:00

Contributor

At the moment _use_current can cause the defconfig to become malformed due to changes done by the prepare() function.

Skip them all entirely when _use_current is used, but add a check for the major version, warn the user if major version was updated, but _use_current was still set.

At the moment _use_current can cause the defconfig to become malformed due to changes done by the prepare() function. Skip them all entirely when _use_current is used, but add a check for the major version, warn the user if major version was updated, but _use_current was still set.

yarost12 added 2 commits 2024-11-19 01:23:50 +01:00

Separate defconfig creation from re-use logic 7e8818327b

At the moment when _use_current=y is passed to the package
compilation - the script still re-creates the defconfig which can
cause errors and cause the menuconfig to show up outta nowhere.

Fix this by bypassing the logic completely, I think that
anyone using the _use_current=y knows what they're doing
so we should be fine.

Warn the user if the major version was upgraded when _use_current is set 0d4fdeb204

It might be a good idea to regen the defconfig
if the major version was updated

yarost12 requested review from JeremyStarTM 2024-11-19 01:24:09 +01:00

JeremyStarTM commented

2024-11-19 01:31:06 +01:00

Owner

lgtm

JeremyStarTM commented

2024-11-19 01:31:21 +01:00

Owner

won't merge it tho as it's still marked as a draft.

edit: just noticed your emails. i'll try fixing the compilation error:

patching file mm/mmap.c
Hunk #1 FAILED at 1881.
1 out of 1 hunk FAILED -- saving rejects to file mm/mmap.c.rej

won't merge it tho as it's still marked as a draft. edit: just noticed your emails. i'll try fixing the compilation error: ```plain patching file mm/mmap.c Hunk #1 FAILED at 1881. 1 out of 1 hunk FAILED -- saving rejects to file mm/mmap.c.rej ```

JeremyStarTM self-assigned this 2024-11-19 01:38:38 +01:00

JeremyStarTM added 1 commit 2024-11-19 01:55:11 +01:00

Add comments + rename create_defconfig method 200949718f

JeremyStarTM changed title from ~~[Draft] Proposed changes to the _use_current functionality~~ to Proposed changes to the _use_current functionality

2024-11-19 01:55:21 +01:00

JeremyStarTM commented

2024-11-19 01:57:14 +01:00

Owner

We can safely ignore patching errors. These most commonly occur when the kernel version and clr patches version differ. The kernel however still compiles fine (at least for the first minutes). Added some nice comments to all methods though, always good to have them.

JeremyStarTM merged commit 200949718f into master

2024-11-19 01:57:27 +01:00

JeremyStarTM commented

2024-11-19 02:16:22 +01:00

Owner

missed that review part completely wow

yarost12 commented

2024-11-19 21:17:09 +01:00

Author

Contributor

Awesome, thanks for the updates and merge.

JeremyStarTM commented

2024-11-19 22:34:44 +01:00

Owner

No problem. PR is good, especially for being your first one on this repo. Good job :)

Proposed changes to the _use_current functionality #1