JeremyStarTM/aur-linux-clear
JeremyStarTM/aur-linux-clear
1
0
Fork 1
Code Issues Pull requests Activity

PKGBUILD: apply extra uarches patch even when defconfig is copied #3

Merged
JeremyStarTM merged 1 commit from yarost12/aur-linux-clear:YF-allow-using-extra-uarches-even-with-copied-config into master 2024-12-13 09:11:30 +01:00
Conversation 2 Commits 1 Files changed 1 +5 -5
yarost12 commented 2024-12-11 18:04:56 +01:00
Contributor
Copy link

Otherwise some default value is set which will result in a misoptimization.

Otherwise some default value is set which will result in a misoptimization.
yarost12 added 1 commit 2024-12-11 18:04:57 +01:00 
Otherwise some default value is set which will result in a misoptimization.
yarost12 reviewed 2024-12-11 18:05:46 +01:00
PKGBUILD Outdated
@ -315,10 +320,9 @@ update_defconfig() {
make ${BUILD_FLAGS[*]} olddefconfig
diff -u $srcdir/cl-linux/config .config || :
# Patch with kernel_compiler_patch patches
yarost12 commented 2024-12-11 18:05:46 +01:00
Author
Contributor
Copy link

It's not entirely clear if we really need to make olddefconfig here, up to you whether to leave this in or move/remove it. @JeremyStarTM

It's not entirely clear if we really need to make olddefconfig here, up to you whether to leave this in or move/remove it. @JeremyStarTM
JeremyStarTM commented 2024-12-11 19:49:56 +01:00
Owner
Copy link

olddefconfig is usually executed to set unset kconfig settings. This is useful when updating the kernel and reusing the kconfig from the previous kernel version. I think we should leave that inside

`olddefconfig` is usually executed to set unset kconfig settings. This is useful when updating the kernel and reusing the kconfig from the previous kernel version. I think we should leave that inside
yarost12 commented 2024-12-11 23:32:44 +01:00
Author
Contributor
Copy link

Ok, left the olddefconfig call, but the comment refers to nothing now, so I will remove it.

Ok, left the olddefconfig call, but the comment refers to nothing now, so I will remove it.
JeremyStarTM commented 2024-12-11 19:50:35 +01:00
Owner
Copy link

lgtm, waiting for reply to #3 (comment)

lgtm, waiting for reply to https://git.staropensource.de/JeremyStarTM/aur-linux-clear/pulls/3#issuecomment-134
yarost12 force-pushed YF-allow-using-extra-uarches-even-with-copied-config from 273f8eef39 to 6da003f220 2024-12-11 23:33:27 +01:00 Compare
yarost12 commented 2024-12-12 00:42:04 +01:00
Author
Contributor
Copy link

lgtm, waiting for reply to #3 (comment)

Done.

> lgtm, waiting for reply to https://git.staropensource.de/JeremyStarTM/aur-linux-clear/pulls/3#issuecomment-134 Done.
JeremyStarTM merged commit 6da003f220 into master 2024-12-13 09:11:30 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: JeremyStarTM/aur-linux-clear#3
No description provided.
Delete branch "yarost12/aur-linux-clear:YF-allow-using-extra-uarches-even-with-copied-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?